[tsp-client] Batch generation #13023
Merged
+511
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Relies on #13027 |
timotheeguerin
approved these changes
Nov 21, 2025
…tsp-client/batch
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds batch generation support to the tsp-client tool, enabling users to process multiple TypeSpec directories in a single command by defining a batch configuration in the parent tsp-location.yaml file.
- Introduces a new
batchfield toTspLocationinterface for specifying multiple subdirectories - Makes
directory,commit, andrepofields optional inTspLocationto support batch mode - Implements recursive batch processing in
updateCommandthat processes each subdirectory independently
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/tsp-client/src/typespec.ts | Modified TspLocation interface to support batch mode by making standard fields optional and adding batch array field |
| tools/tsp-client/src/fs.ts | Updated readTspLocation to validate batch configurations and handle optional directory normalization |
| tools/tsp-client/src/commands.ts | Added processBatchUpdate function and modified updateCommand, syncCommand, and generateCommand to support batch processing |
| tools/tsp-client/src/npm.ts | Added tspClientCommand helper function (currently unused) |
| tools/tsp-client/test/commands.spec.ts | Added tests for batch configuration reading and batch directory processing with/without local spec paths |
| tools/tsp-client/test/examples/batch/**/*.yaml | Added test fixtures for batch configuration including parent and child tsp-location.yaml files |
| tools/tsp-client/test/examples/batch/service/**/*.tsp | Added TypeSpec test fixtures for rbac, settings, and restore services |
| tools/tsp-client/test/examples/batch/service/package.json | Added emitter package configuration for batch test scenarios |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…-tools into tsp-client/batch
mccoyp
approved these changes
Nov 21, 2025
Member
Author
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12963